-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error states for general, passkey and wallet-connect errors #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iykazrji
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
September 10, 2024 20:04
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobChangCA
changed the title
Feat: add Error states for General, Passkey and Wallet Connect errors
feat: add Error states for General, Passkey and Wallet Connect errors
Sep 11, 2024
RobChangCA
changed the title
feat: add Error states for General, Passkey and Wallet Connect errors
feat: add error states for general, passkey and wallet-connect errors
Sep 11, 2024
iykazrji
force-pushed
the
lazer/error-state
branch
from
September 11, 2024 14:51
2ab29c5
to
e2f1e65
Compare
rthomare
reviewed
Sep 11, 2024
Couple of high level thoughts in general to speed up reviews!
|
RobChangCA
force-pushed
the
lazer/error-state
branch
from
September 13, 2024 14:16
4e0993e
to
88a8aba
Compare
rthomare
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces new error handling features, updates dependencies, and refactors components in the
account-kit/react
project.Detailed summary
msw
andmsw-storybook-addon